Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing unit test issues on tintop master branch #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing unit test issues on tintop master branch #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b774824
Removing tests that point to non-existent resources
ericdscott Feb 6, 2019
1aa0d51
Revising some dependencies and documenting changes. Unit tests now work
ericdscott Feb 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ dkm-commandlist.txt
*/.project
*/.settings
*.versionsBackup
*#
23 changes: 22 additions & 1 deletion docs/download.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,28 @@ <h2 id="Recompiling_PIKES_from_sources"><a name="sources" class="anchor" id="sou
</pre>
</div>
</div>
<p>You’ll get the <tt>pikes-tintop-1.0-SNAPSHOT-jar-with-dependencies.jar</tt> package into the <tt>pikes-tintop/target/</tt> folder. Just copy it to the running folder and restart PIKES.</p>
<p>You’ll get the <tt>pikes-tintop-1.0-SNAPSHOT-jar-with-dependencies.jar</tt> package into the <tt>pikes-tintop/target/</tt> folder. Just copy it to the running folder and restart PIKES.</p>
<p>
In the event that there are build issues with the <i>devel</i> branches, you may want to check out the master branches instead (which reference an earlier version of the Stanford Core). To get the unit tests to run on the master branch, you may need to make pointers to certain models in the working downloadable version(unix-centric instructions):
<ul>
<li>Follow the <a href=#download>instructions above</a> to download the working version. Let's say that's in the $DOWNLOADED_PIKES directory.
</li>
<li>
Make symbolic links from the ./pikes directory to certain data models:
<pre>
ln -sf $DOWLOADED_PIKES/models models
ln -sf $DOWNLOADED_PIKES/wordnet wordnet
ln -sf $DOWNLOADED_PIKES/ukb ukb
</pre>
</li>
<li>
If you see complaints about not being able to run UKB libraries, you may need to follow the <a href=#mac>instructions above</a> for installing UKB natively on your machine.
</li>
</ul>
</p>
<p>
After following the above instructions, you should be able to run all of the unit tests for the master branch in your favorite IDE, and step through the code.
</p>
</div>
</div>
</div>
Expand Down
14 changes: 14 additions & 0 deletions pikes-tintop/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,20 @@
<artifactId>Semafor</artifactId>
<version>3.0-alpha-04</version>
</dependency>
<!-- https://mvnrepository.com/artifact/uk.ac.susx.informatics/morpha-stemmer -->
<dependency>
<groupId>uk.ac.susx.informatics</groupId>
<artifactId>morpha-stemmer</artifactId>
<version>1.0.1</version>
</dependency>
<!-- https://mvnrepository.com/artifact/org.pcollections/pcollections -->
<dependency>
<groupId>org.pcollections</groupId>
<artifactId>pcollections</artifactId>
<version>2.1.2</version>
</dependency>



</dependencies>

Expand Down
3 changes: 2 additions & 1 deletion pikes-tintop/src/main/java/eu/fbk/dkm/pikes/tintop/annotators/Defaults.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ public static Properties classProperties() {
public static final String MATE_MODEL_BE = MODEL_FOLDER + "mate_be.model";

public static final String DBPS_ANNOTATOR = "dbpedia-candidates";
public static final String DBPS_ADDRESS = "http://spotlight.sztaki.hu:2222/rest";

public static final String DBPS_ADDRESS = "https://api.dbpedia-spotlight.org/en";
public static final double DBPSC_MIN_CONFIDENCE = 0.01;
public static final double DBPSC_FIRST_CONFIDENCE = 0.5;
public static final double DBPS_MIN_CONFIDENCE = 0.33;
Expand Down
44 changes: 0 additions & 44 deletions pikes-tintop/src/test/java/eu/fbk/dkm/pikes/tintop/MorphTest.java
View file
Open in desktop

This file was deleted.

99 changes: 0 additions & 99 deletions pikes-tintop/src/test/java/eu/fbk/dkm/pikes/tintop/Ontonotes2Giulio.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion pikes-twm/src/main/java/eu/fbk/dkm/pikes/twm/DBpediaSpotlightAnnotate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class DBpediaSpotlightAnnotate extends Linking {

private static String LABEL = "dbpedia-annotate";
private String confidence;
public static final String DBPS_ADDRESS = "http://spotlight.sztaki.hu:2222/rest";
public static final String DBPS_ADDRESS = "https://api.dbpedia-spotlight.org/en";
public static final double DBPS_MIN_CONFIDENCE = 0.33;

public DBpediaSpotlightAnnotate(Properties properties) {
Expand Down
5 changes: 5 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@
<id>fbk-repo</id>
<url>https://raw.githubusercontent.com/fbk/mvn-repo/master/releases</url>
</repository>
<repository> <!-- home to morpha-stemmer -->
<id>KnowItAll</id>
<url>http://knowitall.cs.washington.edu/maven2/</url>
</repository>

</repositories>

<developers>
Expand Down