Report total watering time as part of the water use summary #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dknowles2
reviewed
Jun 7, 2024
pydrawise/client.py
Outdated
| summary.total_active_use += active_use | ||
| summary.active_use_by_zone_id.setdefault(entry.run_event.zone.id, 0) | ||
| summary.active_use_by_zone_id[entry.run_event.zone.id] += active_use | ||
| if entry.run_event is not None and entry.run_event.zone is not None: |
There was a problem hiding this comment.
Suggested change
| if entry.run_event is not None and entry.run_event.zone is not None: | |
| if entry.run_event is None or entry.run_event.zone is None: | |
| continue |
dknowles2
reviewed
Jun 7, 2024
dknowles2
approved these changes
Jun 7, 2024
|
@dknowles2 is there still anything needed before merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report total watering time as part of the water use summary. Right now, we only report remaining watering time during an active watering cycle.
Refactored the code to allow fetching the water use summary even in the absence of a flow sensor. In this case, we only report the total watering time. The total water use will be zero. The allows us to expose the daily total watering time in HA even for folks that don't own a flow sensor.