Prominent notice that this repo is unmaintained #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad661
approved these changes
Dec 11, 2017
README.md
Outdated
| @@ -32,6 +45,8 @@ To view a module documentation execute: | |||
|
|
|||
| ### manageiq_provider module | |||
|
|
|||
| **Replacement**: upstream https://docs.ansible.com/ansible/devel/manageiq_provider_module.html | |||
There was a problem hiding this comment.
nitpick: should be consistent with the messages in all other files.
.github/CONTRIBUTING.md
Outdated
| @@ -0,0 +1,9 @@ | |||
| # OBSOLETE — Upstreaming into Ansible itself | |||
|
|
|||
| This repository is no longer maintained. | |||
There was a problem hiding this comment.
nitpick: I'd put "no longer maintained" in bold, so it will be more prominent.
|
LGTM. |
|
@cben do you have permissions to close this repo for new PRs ? |
yaacov
approved these changes
Dec 11, 2017
|
Addressed comments. I'll let myself merge without further review because it's just text, and don't want to forget this for another 3 weeks :-/ I don't have permissions to archive this repo, but I also don't want to archive until we're done upstreaming. |
|
And by now ansible.com moved my cheese, all links 404... Fix soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both users and contributor might look at this repo and not realize Ansible itself is the new place. (Evidence: we'd got a couple contributions here - #79, #86).
Added prominent notice to README (and a CONTRIBUTING file too which should appear when trying to open issue/PR here).
I don't want to completely close this repo to PRs/issues for now, in case someone still needs a module from here and wants to fix a bug.
I do want to signal we'll spend minimal efforts here.
@elad661 @yaacov @snecklifter Please review
I've updated #85 with current upstreaming status & interface changes.
And I'm going through PRs & issues on this repo, hope to close most.