Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serializing an FSArray without any elements breaks #211

Closed
reckart opened this issue Sep 22, 2021 · 0 comments
Closed

Serializing an FSArray without any elements breaks #211

reckart opened this issue Sep 22, 2021 · 0 comments
Assignees
@reckart
Labels
🐛Bug
Milestone
0.6.0

Comments

@reckart
Copy link
Member

reckart commented Sep 22, 2021 •
edited
Loading

Describe the bug
Serializing an FSArray without any elements produces an XML attribute like xxx="None".
Might be limited to the JSON branch - need to check.

Expected behavior
If an array is empty serialize a xxx="" case. If the arrays does not even exist, omit the attribute.

Please complete the following information:

  • Version: 0.6.0-SNAPSHOT, maybe even 0.5.3
@reckart reckart added this to the 0.6.0 milestone Sep 22, 2021
@reckart reckart self-assigned this Sep 22, 2021
reckart added a commit that referenced this issue Sep 22, 2021
@reckart
#211 - Serializing an FSArray without any elements breaks
fb7fe00 
- Handle empty arrays during XMI (de)serialization
- Handle array features where actually no target array exists
- Upgraded tests to include empty and non-existing arrays
reckart added a commit that referenced this issue Sep 22, 2021
@reckart
Merge pull request #214 from dkpro/bugfix/211-Serializing-an-FSArray-…
2105021 
…without-any-elements-breaks

#211 - Serializing an FSArray without any elements breaks
@reckart reckart closed this as completed Sep 22, 2021
reckart added a commit that referenced this issue Sep 22, 2021
@reckart
Merge branch 'main' into feature/212-Allow-loading-saving-XMI/typesys…
fe9ab00 
…tems-from-to-Path

* main:
  #211 - Serializing an FSArray without any elements breaks
reckart added a commit that referenced this issue Sep 27, 2021
@reckart
Merge branch 'main' into feature/168-Experimental-JSON-CAS-support
a77935d 
* main:
  No issue. Formatting.
  #215 - Ability to exclude types from cas_to_comparable_text
  #212 - Allow loading/saving XMI/typesystems from/to Path
  #211 - Serializing an FSArray without any elements breaks
  #212 - Allow loading/saving XMI/typesystems from/to Path

# Conflicts:
#	cassis/util.py
reckart added a commit that referenced this issue Sep 27, 2021
@reckart
Merge branch 'feature/168-Experimental-JSON-CAS-support' of https://g…
e607dd5 
…ithub.com/dkpro/dkpro-cassis into feature/168-Experimental-JSON-CAS-support

* 'feature/168-Experimental-JSON-CAS-support' of https://github.com/dkpro/dkpro-cassis:
  No issue. Formatting.
  #215 - Ability to exclude types from cas_to_comparable_text
  #212 - Allow loading/saving XMI/typesystems from/to Path
  #211 - Serializing an FSArray without any elements breaks
  #212 - Allow loading/saving XMI/typesystems from/to Path
  #168 - Experimental JSON CAS support
  #168 - Experimental JSON CAS support
  #168 - Experimental JSON CAS support
  #209 - Parsing an array that was serialized using multipleReferencesAllowed=true fails
  - Do not execute performance "tests" when running make test - Update JSON reference data with new data from UIMA Java SDK - including CAS examples using emojis and other Unicode characters - Enabled character offset conversion on import/export in JSON (de)serializer
  #209 - Parsing an array that was serialized using multipleReferencesAllowed=true fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
1 participant
@reckart