Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating point special values not serialized as expected #219

Closed
reckart opened this issue Sep 27, 2021 · 0 comments
Closed

Floating point special values not serialized as expected #219

reckart opened this issue Sep 27, 2021 · 0 comments
Assignees
@reckart
Labels
🐛Bug
Milestone
0.6.0

Comments

@reckart
Copy link
Member

reckart commented Sep 27, 2021

Describe the bug
Floating point special values such as not-a-number are serialized in the way Python uses them (i.e. nan) and Java doesn't like these - it expects NaN.

To Reproduce

  • I'll provide a unit test with the MR.

Expected behavior
The files should be interoperable between the UIMA Java SDK and DKPro Cassis.

Please complete the following information:

  • Version: 0.5.x
@reckart reckart added this to the 0.6.0 milestone Sep 27, 2021
@reckart reckart self-assigned this Sep 27, 2021
reckart added a commit that referenced this issue Sep 27, 2021
@reckart
#219 - Floating point special values not serialized as expected
5c2abc5 
- Serialize the values that Java also serializes for floating point special values
- Added unit test
reckart added a commit that referenced this issue Sep 27, 2021
@reckart
Merge pull request #220 from dkpro/bugfix/219-Floating-point-special-…
570763d 
…values-not-serialized-as-expected

#219 - Floating point special values not serialized as expected
@reckart reckart closed this as completed Sep 27, 2021
reckart added a commit that referenced this issue Sep 27, 2021
@reckart
Merge branch 'main' into feature/168-Experimental-JSON-CAS-support
2c14fcd 
* main:
  #221 - Unable to parse empty arrays
  #219 - Floating point special values not serialized as expected
reckart added a commit that referenced this issue Sep 27, 2021
@reckart
#219 - Floating point special values not serialized as expected
a62bdb9 
- Include floating point special values in randomized tests
reckart added a commit that referenced this issue Sep 27, 2021
@reckart
Merge branch 'main' into feature/168-Experimental-JSON-CAS-support
dd7e1d2 
* main:
  No issue. Fix issues with arrays in cas_to_comparable_text.
  #219 - Floating point special values not serialized as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
1 participant
@reckart