Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167 - Cant serialize byte arrays #176

Merged
merged 2 commits into from
Aug 14, 2021

Conversation

jcklie
Copy link
Collaborator

@jcklie jcklie commented Aug 14, 2021

Turns out that there was no support for primitive array serialization/deserialization at all

- Add function to check whether something is a primitive array
- Add basic support for serializing/deserializing primitive arrays
@jcklie jcklie added this to the 0.6.0 milestone Aug 14, 2021
@jcklie jcklie self-assigned this Aug 14, 2021
@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #176 (4da53b7) into master (9c7d6d1) will decrease coverage by 0.37%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   97.91%   97.53%   -0.38%     
==========================================
  Files           9        9              
  Lines        1822     1869      +47     
==========================================
+ Hits         1784     1823      +39     
- Misses         38       46       +8     
Impacted Files Coverage Δ
cassis/xmi.py 96.41% <88.46%> (-1.94%) ⬇️
cassis/typesystem.py 96.70% <100.00%> (+0.05%) ⬆️
tests/test_typesystem.py 99.17% <100.00%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c7d6d1...4da53b7. Read the comment docs.

@jcklie jcklie merged commit 9db7617 into master Aug 14, 2021
@jcklie jcklie deleted the bugfix/167-cant-serialize-byte-arrays branch August 14, 2021 12:23
reckart added a commit that referenced this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant