Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#236 - Long output when printing type #237

Merged
merged 2 commits into from
Nov 15, 2021
Merged

#236 - Long output when printing type #237

merged 2 commits into from
Nov 15, 2021

Conversation

jcklie
Copy link
Collaborator

@jcklie jcklie commented Nov 15, 2021

  • Add str to type and feature

@jcklie
#236 - Long output when printing type
c94ca53 
- Add __str__ to type and feature
@jcklie jcklie added this to the 0.6.2 milestone Nov 15, 2021
@jcklie jcklie requested a review from reckart November 15, 2021 14:32
@jcklie jcklie self-assigned this Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 15, 2021 •
edited
Loading

Codecov Report

Merging #237 (23ab0d4) into main (ee4dbfc) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   96.14%   96.08%   -0.07%     
==========================================
  Files           4        4              
  Lines        1402     1404       +2     
==========================================
+ Hits         1348     1349       +1     
- Misses         54       55       +1
Impacted Files Coverage Δ
cassis/typesystem.py 95.21% <50.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4dbfc...23ab0d4. Read the comment docs.

@jcklie
#236 - Long output when printing type
23ab0d4 
- Remove __str__ for feature
@jcklie jcklie merged commit 307064a into main Nov 15, 2021
@jcklie jcklie deleted the feature/236-type-str-repr branch November 15, 2021 16:20
reckart added a commit that referenced this pull request Dec 12, 2021
@reckart
Merge branch 'main' into feature/168-Experimental-JSON-CAS-support
397d752 
* main:
  #238 - Error parsing FSList in CTAKES XMi
  #238 - Error parsing FSList in CTAKES XMi
  #238 - Error parsing FSList in CTAKES XMi
  Create CITATION.cff
  #236 - Long output when printing type (#237)

% Conflicts:
%	cassis/cas.py
reckart added a commit that referenced this pull request Dec 12, 2021
@reckart
Merge branch 'main' into feature/168-Experimental-JSON-CAS-support
9cdd945 
* main:
  #238 - Error parsing FSList in CTAKES XMi
  #238 - Error parsing FSList in CTAKES XMi
  #238 - Error parsing FSList in CTAKES XMi
  Create CITATION.cff
  #236 - Long output when printing type (#237)

% Conflicts:
%	cassis/cas.py
reckart added a commit that referenced this pull request Dec 12, 2021
@reckart
Merge branch 'main' into feature/168-Experimental-JSON-CAS-support
0566e37 
* main:
  #238 - Error parsing FSList in CTAKES XMi
  #238 - Error parsing FSList in CTAKES XMi
  #238 - Error parsing FSList in CTAKES XMi
  Create CITATION.cff
  #236 - Long output when printing type (#237)

% Conflicts:
%	cassis/cas.py
@reckart reckart modified the milestones: 0.6.2, 0.7.0 Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reckart reckart reckart approved these changes

Assignees

@jcklie jcklie

Labels
🆕Enhancement
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcklie @reckart