Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid datasets being extracted outside their target directory #1325

Closed
reckart opened this issue Feb 12, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@reckart
Copy link
Member

commented Feb 12, 2019

It should be ensured that datasets are only extracted inside their respective cache folder.

@reckart reckart added this to the 1.11.0 milestone Feb 12, 2019

@reckart reckart self-assigned this Feb 12, 2019

reckart added a commit that referenced this issue Feb 12, 2019

#1325 - Avoid datasets being extracted outside their target directory
- Check that extracted files are under the target directory

reckart added a commit that referenced this issue Feb 12, 2019

#1325 - Avoid datasets being extracted outside their target directory
- Fix extration of base path from archive file location

reckart added a commit that referenced this issue Apr 10, 2019

reckart added a commit that referenced this issue Apr 10, 2019

#1325 - Avoid datasets being extracted outside their target directory
- Fix getting the archive base (i.e. the path without the extension)

reckart added a commit that referenced this issue Apr 10, 2019

reckart added a commit that referenced this issue Apr 16, 2019

Merge pull request #1326 from dkpro/bugfix/1325-Avoid-datasets-being-…
…extracted-outside-their-target-directory

#1325 avoid datasets being extracted outside their target directory

@reckart reckart closed this Apr 16, 2019

reckart added a commit that referenced this issue Apr 16, 2019

Merge branch 'master' into 2.0.x
* master:
  #1325 - Avoid datasets being extracted outside their target directory
  #1325 - Avoid datasets being extracted outside their target directory
  #1325 - Avoid datasets being extracted outside their target directory
  #1338 - Factor CAS <-> brat conversion code into Pojos
  #1338 - Factor CAS <-> brat conversion code into Pojos
  #1325 - Avoid datasets being extracted outside their target directory
  #1325 - Avoid datasets being extracted outside their target directory

reckart added a commit to tilmanbeck/dkpro-core that referenced this issue Apr 19, 2019

Merge branch 'master' into bugfix/1305-update_treetager-build.xml
* master:
  dkpro#1325 - Avoid datasets being extracted outside their target directory
  dkpro#1325 - Avoid datasets being extracted outside their target directory
  dkpro#1325 - Avoid datasets being extracted outside their target directory
  dkpro#1338 - Factor CAS <-> brat conversion code into Pojos
  dkpro#1338 - Factor CAS <-> brat conversion code into Pojos
  dkpro#1322 - Upgrade to OpenNLP 1.9.1
  dkpro#1308 - integrate mystem
  dkpro#1327 - Update LIF support
  dkpro#1327 - Update LIF support
  dkpro#1329 - Span annotations with slot features may disappear from WebAnno TSV
  dkpro#1329 - Span annotations with slot features may disappear from WebAnno TSV
  dkpro#1329 - Span annotations with slot features may disappear from WebAnno TSV
  dkpro#1327 - Update LIF support
  dkpro#1325 - Avoid datasets being extracted outside their target directory
  dkpro#1325 - Avoid datasets being extracted outside their target directory
  dkpro#1323 - File extension generated by BinaryCasWriter does not contain dot
  dkpro#858 - Out-of-tagset tags should map to the generic type
  dkpro#858 - Out-of-tagset tags should map to the generic type

reckart added a commit that referenced this issue Apr 26, 2019

Merge branch 'master' into feature/186-change-maven-coordinates
* master: (21 commits)
  #1305 - Update TreeTagger models in build.xml
  #1325 - Avoid datasets being extracted outside their target directory
  #1325 - Avoid datasets being extracted outside their target directory
  #1325 - Avoid datasets being extracted outside their target directory
  #1338 - Factor CAS <-> brat conversion code into Pojos
  #1338 - Factor CAS <-> brat conversion code into Pojos
  #1322 - Upgrade to OpenNLP 1.9.1
  #1308 - integrate mystem
  #1327 - Update LIF support
  #1327 - Update LIF support
  #1329 - Span annotations with slot features may disappear from WebAnno TSV
  #1329 - Span annotations with slot features may disappear from WebAnno TSV
  #1329 - Span annotations with slot features may disappear from WebAnno TSV
  #1327 - Update LIF support
  #1325 - Avoid datasets being extracted outside their target directory
  #1325 - Avoid datasets being extracted outside their target directory
  #1323 - File extension generated by BinaryCasWriter does not contain dot
  #858 - Out-of-tagset tags should map to the generic type
  #1239 - Rename NYTCollectionReader to NitfReader
  #858 - Out-of-tagset tags should map to the generic type
  ...

% Conflicts:
%	dkpro-core-asl/pom.xml
%	dkpro-core-io-lif-asl/src/test/java/de/tudarmstadt/ukp/dkpro/core/io/lif/LifReaderWriterTest.java
%	dkpro-core-io-lif-asl/src/test/java/de/tudarmstadt/ukp/dkpro/core/io/lif/LifWriterTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.