Avoid datasets being extracted outside their target directory #1325

reckart · 2019-02-12T13:00:10Z

It should be ensured that datasets are only extracted inside their respective cache folder.

- Check that extracted files are under the target directory

- Fix extration of base path from archive file location

- Fixing endless loop when extracting

- Fix getting the archive base (i.e. the path without the extension)

- Fixing extraction path ... again

…extracted-outside-their-target-directory #1325 avoid datasets being extracted outside their target directory

* master: #1325 - Avoid datasets being extracted outside their target directory #1325 - Avoid datasets being extracted outside their target directory #1325 - Avoid datasets being extracted outside their target directory #1338 - Factor CAS <-> brat conversion code into Pojos #1338 - Factor CAS <-> brat conversion code into Pojos #1325 - Avoid datasets being extracted outside their target directory #1325 - Avoid datasets being extracted outside their target directory

* master: dkpro#1325 - Avoid datasets being extracted outside their target directory dkpro#1325 - Avoid datasets being extracted outside their target directory dkpro#1325 - Avoid datasets being extracted outside their target directory dkpro#1338 - Factor CAS <-> brat conversion code into Pojos dkpro#1338 - Factor CAS <-> brat conversion code into Pojos dkpro#1322 - Upgrade to OpenNLP 1.9.1 dkpro#1308 - integrate mystem dkpro#1327 - Update LIF support dkpro#1327 - Update LIF support dkpro#1329 - Span annotations with slot features may disappear from WebAnno TSV dkpro#1329 - Span annotations with slot features may disappear from WebAnno TSV dkpro#1329 - Span annotations with slot features may disappear from WebAnno TSV dkpro#1327 - Update LIF support dkpro#1325 - Avoid datasets being extracted outside their target directory dkpro#1325 - Avoid datasets being extracted outside their target directory dkpro#1323 - File extension generated by BinaryCasWriter does not contain dot dkpro#858 - Out-of-tagset tags should map to the generic type dkpro#858 - Out-of-tagset tags should map to the generic type

* master: (21 commits) #1305 - Update TreeTagger models in build.xml #1325 - Avoid datasets being extracted outside their target directory #1325 - Avoid datasets being extracted outside their target directory #1325 - Avoid datasets being extracted outside their target directory #1338 - Factor CAS <-> brat conversion code into Pojos #1338 - Factor CAS <-> brat conversion code into Pojos #1322 - Upgrade to OpenNLP 1.9.1 #1308 - integrate mystem #1327 - Update LIF support #1327 - Update LIF support #1329 - Span annotations with slot features may disappear from WebAnno TSV #1329 - Span annotations with slot features may disappear from WebAnno TSV #1329 - Span annotations with slot features may disappear from WebAnno TSV #1327 - Update LIF support #1325 - Avoid datasets being extracted outside their target directory #1325 - Avoid datasets being extracted outside their target directory #1323 - File extension generated by BinaryCasWriter does not contain dot #858 - Out-of-tagset tags should map to the generic type #1239 - Rename NYTCollectionReader to NitfReader #858 - Out-of-tagset tags should map to the generic type ... % Conflicts: % dkpro-core-asl/pom.xml % dkpro-core-io-lif-asl/src/test/java/de/tudarmstadt/ukp/dkpro/core/io/lif/LifReaderWriterTest.java % dkpro-core-io-lif-asl/src/test/java/de/tudarmstadt/ukp/dkpro/core/io/lif/LifWriterTest.java

reckart added 🐛Bug Something isn't working Module-api.datasets labels Feb 12, 2019

reckart added this to the 1.11.0 milestone Feb 12, 2019

reckart self-assigned this Feb 12, 2019

reckart added a commit that referenced this issue Feb 12, 2019

#1325 - Avoid datasets being extracted outside their target directory

ceb749a

- Check that extracted files are under the target directory

reckart added a commit that referenced this issue Feb 12, 2019

#1325 - Avoid datasets being extracted outside their target directory

0d7048e

- Fix extration of base path from archive file location

reckart added a commit that referenced this issue Apr 10, 2019

#1325 - Avoid datasets being extracted outside their target directory

b7ab1ed

- Fixing endless loop when extracting

reckart added a commit that referenced this issue Apr 10, 2019

#1325 - Avoid datasets being extracted outside their target directory

0371975

- Fix getting the archive base (i.e. the path without the extension)

reckart added a commit that referenced this issue Apr 10, 2019

#1325 - Avoid datasets being extracted outside their target directory

6bdca97

- Fixing extraction path ... again

reckart added a commit that referenced this issue Apr 16, 2019

Merge pull request #1326 from dkpro/bugfix/1325-Avoid-datasets-being-…

9c4c5d5

…extracted-outside-their-target-directory #1325 avoid datasets being extracted outside their target directory

reckart closed this as completed Apr 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid datasets being extracted outside their target directory #1325

Avoid datasets being extracted outside their target directory #1325

reckart commented Feb 12, 2019

Avoid datasets being extracted outside their target directory #1325

Avoid datasets being extracted outside their target directory #1325

Comments

reckart commented Feb 12, 2019