Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1240 - Ensures DictionaryAnnotator matches all token #1241

Merged
merged 1 commit into from
May 29, 2018

Conversation

jkirsch
Copy link
Contributor

@jkirsch jkirsch commented May 27, 2018

No description provided.

- removes the code to drop the last token within in a sentence when looking for dictionary matches
@ukp-svc-jenkins
Copy link

Can one of the admins verify this patch?

@jkirsch jkirsch changed the title master #1240 - Ensures DictionaryAnnotator matches all token May 27, 2018
@reckart
Copy link
Member

reckart commented May 28, 2018

Jenkins, can you please test this?

@reckart
Copy link
Member

reckart commented May 28, 2018

Jenkins, can you test this please?

@reckart
Copy link
Member

reckart commented May 29, 2018

Thanks :) Merging this under Section 5 (Submission of Contributions) of the ASL as it is a minimal change.

@jkirsch still please check our contribution guidelines, in particular the contributor agreements.

@reckart reckart changed the base branch from master to 1.9.x May 29, 2018 10:27
@reckart reckart changed the base branch from 1.9.x to master May 29, 2018 10:27
@reckart reckart added this to the 1.9.3 milestone May 29, 2018
@reckart reckart self-requested a review May 29, 2018 10:29
@reckart reckart added 🐛Bug Something isn't working Module-dictionaryannotator labels May 29, 2018
@reckart reckart merged commit e2bd0d7 into dkpro:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants