Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OmegaWiki.getDefinedMeaningById loads defined meanings twice #2

Open
chmeyer opened this issue Aug 4, 2015 · 0 comments
Open

OmegaWiki.getDefinedMeaningById loads defined meanings twice #2

chmeyer opened this issue Aug 4, 2015 · 0 comments

Comments

@chmeyer
Copy link
Member

chmeyer commented Aug 4, 2015

Originally reported on Google Code with ID 2

The constructor of DefinedMeaning expects an ID and a dbStatements instance which it
uses to load all fields of DefinedMeaning.

The API method OmegaWiki.getDefinedMeaningById(int dmId) expects an ID which it uses
to query the database for the DefinedMeaning's ID (which always equals the given dmId)
and then uses the constructor described above to load the fields.

IMHO, the method could be reimplemented using the single lime

return new DefinedMeaning(dmId, dbStatements);

?

Reported by chmeyer.de on 2014-10-09 09:08:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant