Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider mn and mfn when parsing gender #63

Closed
highsource opened this issue Aug 6, 2018 · 1 comment
Closed

Consider mn and mfn when parsing gender #63

highsource opened this issue Aug 6, 2018 · 1 comment

Comments

@highsource
Copy link
Contributor

In some cases the gender of the substantive is specified as mn or mfn for multiple genders.

Example for an earlier version of Tetragraph:

=== {{Wortart|Substantiv|Deutsch}}, {{mn}} ===

{{mn}} is actually not correct, as it resolves to Mongolisch. The correct version should be {{mn.}}

Example for {{mfn}} is Flipchart.

Neither mn nor mfn are currently considered by the DEPartOfSpeechHandler, in both cases this results in empty list of genders which is obiously incorrect.

I'll fix it and provide a PR.

highsource added a commit to highsource/dkpro-jwktl that referenced this issue Aug 6, 2018
  - Added a reproducing tests for Tetragraph (mn) and Flipchart (mfn)
highsource added a commit to highsource/dkpro-jwktl that referenced this issue Aug 6, 2018
  - Moved gender text parsing to a special-purpose enum.
  - Added recognition of mn
  - Added recognition of mfn
  - Small fixes in tests
highsource added a commit to highsource/dkpro-jwktl that referenced this issue Aug 6, 2018
  - Renamed DEGrammaticalGendersText to DEGendersText as it is closer to
the gender text rather than grammatical genders
@chmeyer chmeyer added this to the JWKTL 1.2.0 milestone Aug 7, 2018
highsource added a commit to highsource/dkpro-jwktl that referenced this issue Aug 7, 2018
  - Added `w` to `DEGendersText` for backwards compatibility
chmeyer added a commit that referenced this issue Aug 9, 2018
@highsource
Copy link
Contributor Author

Since #64 is merged, this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants