Skip to content

Commit

Permalink
Merge branch 'master' into enhancement/24-delete-.bin-files-after-dum…
Browse files Browse the repository at this point in the history
…p-creation
  • Loading branch information
mawiesne committed Oct 7, 2018
2 parents ef2967f + 96eeb0d commit 34dff7c
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 9 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,5 @@ target
*.tmp
*_hypoCountMap

### Embedded DB properties file
de.tudarmstadt.ukp.wikipedia.revisionmachine/src/test/resources/db/*.properties
4 changes: 4 additions & 0 deletions de.tudarmstadt.ukp.wikipedia.revisionmachine/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@
<artifactId>hsqldb</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>mysql</groupId>
<artifactId>mysql-connector-java</artifactId>
</dependency>
</dependencies>
<build>
<plugins>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
import java.lang.reflect.Field;
import java.sql.SQLException;
import java.sql.Timestamp;
import java.time.LocalDateTime;
import java.time.ZoneOffset;
import java.util.Calendar;

import org.junit.*;
Expand All @@ -39,6 +41,12 @@ public class RevisionApiTest extends BaseJWPLTest {

private static Wikipedia wiki = null;

private Timestamp convertToUTC(Timestamp ts) {

final LocalDateTime dt = LocalDateTime.ofInstant(ts.toInstant(), ZoneOffset.UTC);
return Timestamp.valueOf(dt);
}

// The object under test
private RevisionApi revisionApi;

Expand Down Expand Up @@ -176,12 +184,12 @@ public void articleIDTests()
try {
int pageId = wiki.getPage("Car").getPageId();

Timestamp firstDayOfAppearance = revisionApi.getFirstDateOfAppearance(pageId);
Timestamp lastDayOfAppearance = revisionApi.getLastDateOfAppearance(pageId);
Timestamp firstDayOfAppearance = convertToUTC(revisionApi.getFirstDateOfAppearance(pageId));
Timestamp lastDayOfAppearance = convertToUTC(revisionApi.getLastDateOfAppearance(pageId));
int nrOfRevisions = revisionApi.getNumberOfRevisions(pageId);

assertEquals("2004-04-07 02:31:34.0", firstDayOfAppearance.toString());
assertEquals("2009-01-19 04:58:09.0", lastDayOfAppearance.toString());
assertEquals("2004-04-07 00:31:34.0", firstDayOfAppearance.toString());
assertEquals("2009-01-19 03:58:09.0", lastDayOfAppearance.toString());
assertEquals(382, nrOfRevisions);
}
catch (WikiApiException e) {
Expand Down

This file was deleted.

0 comments on commit 34dff7c

Please sign in to comment.