No issue. Find bug warnings fixed.

dkpro · Dec 9, 2018 · 233c7d3 · 233c7d3
1 parent 7760599
commit 233c7d3
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 15 deletions.
diff --git a/...s/src/main/java/org/dkpro/tc/examples/deeplearning/dl4j/sequence/Dl4jSeq2SeqUserCode.java b/...s/src/main/java/org/dkpro/tc/examples/deeplearning/dl4j/sequence/Dl4jSeq2SeqUserCode.java
@@ -26,6 +26,7 @@
 import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStreamReader;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
@@ -231,11 +232,16 @@ private List<List<String>> transformToList(List<String> sentences)
 
     private int getEmbeddingsSize(File embedding) throws Exception
     {
+        String readLine = null;
+        try (BufferedReader br = new BufferedReader(
+                new InputStreamReader(new FileInputStream(embedding), StandardCharsets.UTF_8))) {
+            readLine = br.readLine();
+            br.close();
+        }
 
-        BufferedReader br = new BufferedReader(
-                new InputStreamReader(new FileInputStream(embedding), "utf-8"));
-        String readLine = br.readLine();
-        br.close();
-        return readLine.split(" ").length - 1;
+        if (readLine != null) {
+            return readLine.split(" ").length - 1;
+        }
+        throw new NullPointerException("Value is null");
     }
 }
diff --git a/...eeplearning4j/src/main/java/org/dkpro/tc/ml/deeplearning4j/user/TcDeepLearning4jUser.java b/...eeplearning4j/src/main/java/org/dkpro/tc/ml/deeplearning4j/user/TcDeepLearning4jUser.java
@@ -22,7 +22,7 @@
 public interface TcDeepLearning4jUser
 {
 
-    public void run(File trainVec, File trainOutcome, File testVec, File testOutcome,
+    void run(File trainVec, File trainOutcome, File testVec, File testOutcome,
             File embedding, int seed, int maximumLength, double threshold, File prediction)
         throws Exception;
 

diff --git a/.../main/java/org/dkpro/tc/ml/vowpalwabbit/serialization/VowpalWabbitLoadModelConnector.java b/.../main/java/org/dkpro/tc/ml/vowpalwabbit/serialization/VowpalWabbitLoadModelConnector.java
@@ -232,7 +232,7 @@ private File createInputFile(JCas aJCas, boolean isSequenceMod)
                         @Override
                         public int compare(Instance o1, Instance o2)
                         {
-                            return ((Integer) o1.getSequenceId()).compareTo(o2.getSequenceId());
+                            return Integer.compare(o1.getSequenceId(), o2.getSequenceId());
                         }
                     });
                 }

diff --git a/dkpro-tc-ml/src/main/java/org/dkpro/tc/ml/TcShallowClassifierTaskBase.java b/dkpro-tc-ml/src/main/java/org/dkpro/tc/ml/TcShallowClassifierTaskBase.java
@@ -21,7 +21,6 @@
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.util.List;
-import java.util.Map;
 import java.util.Properties;
 
 import org.dkpro.lab.engine.TaskContext;
@@ -36,8 +35,6 @@
  */
 public abstract class TcShallowClassifierTaskBase extends TcClassifierTaskBase {
 
-	protected Map<String, String> configuration;
-
     @Discriminator(name = DIM_CLASSIFICATION_ARGS)
     protected List<Object> classificationArguments;
 

diff --git a/dkpro-tc-ml/src/main/java/org/dkpro/tc/ml/experiment/ExperimentLearningCurve.java b/dkpro-tc-ml/src/main/java/org/dkpro/tc/ml/experiment/ExperimentLearningCurve.java
@@ -21,7 +21,6 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
-import java.util.Comparator;
 import java.util.List;
 
 import org.apache.commons.io.FileUtils;
@@ -56,7 +55,6 @@
  */
 public class ExperimentLearningCurve extends Experiment_ImplBase {
 
-	protected Comparator<String> comparator;
 	protected int aNumFolds = 10;
 
 	protected InitTask initTask;

diff --git a/dkpro-tc-ml/src/main/java/org/dkpro/tc/ml/experiment/builder/DeepExperimentBuilder.java b/dkpro-tc-ml/src/main/java/org/dkpro/tc/ml/experiment/builder/DeepExperimentBuilder.java
@@ -50,9 +50,6 @@ public class DeepExperimentBuilder
 {
     protected List<TcDeepLearningAdapter> backends;
     protected List<Object> userCodePath;
-
-    File outputFolder;
-
     protected String pythonPath;
     protected String embeddingPath;
     protected int maxLen;