Store original method #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The public interface of adamantium infected classes now allows to receive the original unbound method instance via Class#original_instance_method(method_name)
| # @api private | ||
| # | ||
| def memoized_methods | ||
| @memoized_methods ||= {} |
There was a problem hiding this comment.
Can you define this using Hash.new with a proc that throws the exception on an unknown name. I generally prefer (now) to define that kind of thing at the Hash level when it is the same all the time than duplicating it using #fetch.
I will update the original memory Hash instance to behave like this too.
RBX equalizes UnboundMethod instances via identity
|
@mbj thanks for this, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
Class#original_instance_method(name)as discused in: http://irclog.whitequark.org/rom-rb/2013-07-02#4267764;