Add Adamantium::Mutable #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: Sometimes an object *must* be mutable. But it can end up in a frozen object tree. Instead of using `memoize :foo, :freezer => :noop` the object itself could make sure it does not *really* get frozen. Use. With. Care.
| @@ -0,0 +1,41 @@ | |||
| module Adamantium | |||
| module Mutable | |||
There was a problem hiding this comment.
This is missing a summary. I would probably also write a tiny bit about why it's necessary, because on it's own it's unclear.
|
@mbj I left one comment, but otherwise I'm fine with merging it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
Sometimes an object must be mutable. But it can end up in a frozen
object tree. Instead of using
memoize :foo, :freezer => :nooptheobject itself could make sure it does not really get frozen.
Use. With. Care.