Remove DEFAULT_SIZE from Numeric and Float

dkubb · Jul 26, 2013 · 9461a05 · dkubb · Jul 26, 2013 · cored
1 parent 50606c9
commit 9461a05
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/lib/axiom/attribute/float.rb b/lib/axiom/attribute/float.rb
@@ -6,8 +6,6 @@ class Attribute
     # Represents a Float value in a relation tuple
     class Float < Numeric
 
-      DEFAULT_SIZE = (-::Float::MAX..::Float::MAX).freeze
-
       # The attribute type
       #
       # @return [Class<Types::Float>]

diff --git a/lib/axiom/attribute/numeric.rb b/lib/axiom/attribute/numeric.rb
@@ -9,8 +9,6 @@ class Numeric < Object
               Aggregate::Sum::Methods
       include Equalizer.new(:name, :required?, :size)
 
-      DEFAULT_SIZE = (-::Float::INFINITY..::Float::INFINITY).freeze
-
       inheritable_alias(range: :size)
 
       # The attribute type
@@ -38,10 +36,12 @@ def self.type
       # @api private
       def initialize(_name, options = EMPTY_HASH)
         super
-        size = options.fetch(:size, self.class::DEFAULT_SIZE).to_inclusive
-        @type = type.new do
-          minimum size.first
-          maximum size.last
+        if options.key?(:size)
+          size = options.fetch(:size).to_inclusive
+          @type = type.new do
+            minimum size.first
+            maximum size.last
+          end
         end
       end
 

diff --git a/spec/unit/axiom/attribute/float/size_spec.rb b/spec/unit/axiom/attribute/float/size_spec.rb
@@ -9,7 +9,7 @@
     context 'without :size option passed to constructor' do
       let(:object) { described_class.new(:id) }
 
-      it { should eql(-Float::MAX..Float::MAX) }
+      it { should eql(Axiom::Types::NegativeInfinity..Axiom::Types::Infinity) }
     end
 
     context 'with :size option passed to constructor' do