Fix Rack::Lock mutex usage #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In the previous code if a lock is being waited on and an error was raised, such as by Rack::Timeout, the original code would attempt to unlock a mutex it does not own raising a ThreadError with the error message "Attempt to unlock a mutex which is locked by another thread" This code uses an explicit begin block that starts immediately after the mutex is locked so that when the ensure part runs we know that the mutex belongs to this thread.
* The original code would set the flag for the duration of Rack::Lock#call and then set it back when the method finished. The problem is that the BodyProxy could be executing code that relies on the state of the flag. This change makes sure the application *and* the body proxy see the expected state of the environment.
dkubb
force-pushed
the
fix/rack-lock-mutex-usage
branch
2 times, most recently
from
df97367
to
c1aefd8
Compare
|
Moved to #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes how Rack::Lock uses the mutex and resolves some problems with Rack::Timeout as a result.