Fix crash for MethodObjects#{file,line} returning nil

dkubb · Jan 15, 2014 · 70a040d · dkubb · Jan 16, 2014 · mbj
1 parent 7c681c2
commit 70a040d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/lib/yardstick/parser.rb b/lib/yardstick/parser.rb
@@ -49,7 +49,7 @@ def self.documents
     # @api private
     def self.method_objects
       YARD::Registry.all(:method).sort_by do |method_object|
-        [method_object.file, method_object.line]
+        [method_object.file || '', method_object.line || 0]
       end
     ensure
       YARD::Registry.clear

diff --git a/spec/unit/yardstick/parser/class_methods/parse_string_spec.rb b/spec/unit/yardstick/parser/class_methods/parse_string_spec.rb
@@ -9,9 +9,11 @@
   let(:method_object) { double(:file => 'foo.rb', :line => 4, :docstring => docstring) }
   let(:docstring)     { double('docstring')                                   }
 
+  let(:method_objects) { [method_object] }
+
   before do
     YARD.should_receive(:parse_string).with('body')
-    YARD::Registry.stub(:all).with(:method).and_return([method_object])
+    YARD::Registry.stub(:all).with(:method).and_return(method_objects)
   end
 
   it { should be_a(Yardstick::DocumentSet) }
@@ -25,4 +27,15 @@
 
     its(:docstring) { should eq(docstring) }
   end
+
+  context 'when method one object does not have file information' do
+    let(:method_objects) do
+      [
+        method_object,
+        double(:file => nil, :line => nil, :docstring => docstring)
+      ]
+    end
+
+    it { should be_a(Yardstick::DocumentSet) }
+  end
 end