Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day 3 Comprehensions & Day 4 Notebooks #33

Closed
stemlock opened this issue Jan 14, 2022 · 0 comments · Fixed by #37
Closed

Day 3 Comprehensions & Day 4 Notebooks #33

stemlock opened this issue Jan 14, 2022 · 0 comments · Fixed by #37

Comments

@stemlock
Copy link

16_Comprehensions

  • Consider adding an if, else list comprehension as well (question came up from participants)

16_Answers

  • For each comprehension challenge question, we may want to reinitialize or use new variable names to be used in the answers so the solutions can be created without using the variable names that were already run and set using a for loop (even if the code was incorrect, you would get the correct answer if you reuse the variables)

UPR_Workbook

  • Import statements for 'os' and 'csv' are easy to miss as they fall right under the long introduction text. May want to move these down to Part B where
  • 'csv' module is never called, so there is no need to import it

Part A1

  • The parameter name 'file_name' in section 1.5 is different from the originally used variable 'filename' (no _) used in section 1.1, which could lead to some confusion. We may want to redefine the function parameter as 'filename' to keep it consistent

Part A2

  • In section 2.2, the instructions list the wrong variable names. The 3 new lists should be 'accept_recs', 'examine_recs', 'reject_recs'

Part A3

  • Might be a little out of scope for this workshop, but we could use this part as a good opportunity to introduce Regular Expressions (regex), and demonstrate what a solution using regex might look like.
    *Same comment throughout the notebook. For clarity, may want to use the actual variable name in the markdown
  • We do not specify what strings to use for the 'decision_type' variable. We may want to make that explicit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant