Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize "auto-merge" toggled PRs on the Auto-Tester #49

Closed
wilzbach opened this issue Feb 16, 2017 · 1 comment
Closed

Prioritize "auto-merge" toggled PRs on the Auto-Tester #49

wilzbach opened this issue Feb 16, 2017 · 1 comment
Labels

Comments

@wilzbach
Copy link
Member

Atm the biggest downside imho of the "auto-merge" label system is that the auto-tester doesn't know anything about this status and thus doesn't prioritize "auto-merge" PRs.

@braddr atm the "auto-merge" feature is rather simple and done via labels as follows:

  • Only users with write permissions can add labels (this depends on GH not changing their permissions model in the near future)
  • There are two labels: auto-merge and auto-merge-squash (the latter will perform a squashed merge)
  • Dlang-bot has write-access and will do the merge once all required CI status provider pass

@braddr: Is there an easy way to let "labelled" PRs also be prioritized?
The simplest idea that comes to my mind is to let the Dlang-Bot call the auto-toggle API (https://auto-tester.puremagic.com/addv2/toggle_auto_merge) (and probably disable the GH API request for merge on the auto-tester as (1) the dlang-bot writes the name of the author as part of the merge commit and (2) it probably will fail a lot anyways due to the required CI status checks).
Now I saw that you use a CSRF token for your API. Of course we could scrape the page and thus get a valid token, but I guess you have a better way to let the Bot toggle the auto-merge prioritization?

@wilzbach
Copy link
Member Author

Thamks a lot at @braddr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant