also add byte indices to diagnostic ranges #906
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tools wanting to read from the source file this makes it much easier to look up the code.
Before we tag the new API with start and end locations as new tag, we better just add this together with everything, since then we don't need to change the API again later. Grouping together lines / columns as size_t[2] also makes the previous API better to understand, e.g. because of
size_t line, size_t startColumn, size_t endColumn
now beingsize_t line, size_t[2] columns