Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also add byte indices to diagnostic ranges #906

Merged

Conversation

WebFreak001
Copy link
Member

For tools wanting to read from the source file this makes it much easier to look up the code.

Before we tag the new API with start and end locations as new tag, we better just add this together with everything, since then we don't need to change the API again later. Grouping together lines / columns as size_t[2] also makes the previous API better to understand, e.g. because of size_t line, size_t startColumn, size_t endColumn now being size_t line, size_t[2] columns

For tools wanting to read from the source file this makes it much easier
to look up the code.
@WebFreak001 WebFreak001 merged commit 146fec7 into dlang-community:master Jun 29, 2023
19 checks passed
@WebFreak001 WebFreak001 deleted the diagnostic-index-ranges branch June 29, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant