Also generate ctor calltips for symbols with a callTip #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because in an upcoming PR i have moved This: https://github.com/Pure-D/serve-d/blob/aeae249f9fdc6269c7f4963907eb5ed645d0691c/source/served/commands/complete.d#L969 Into: https://github.com/dlang-community/DCD/blob/2bfd3d004ff7eda2428353d2ab44f389dfd5b8e0/src/dcd/server/autocomplete/util.d#L756 Since it'll set the callTip for struct/class, this logic must be updated to take that into account
RUSShyTwo
added a commit
to RUSShyTwo/DCD
that referenced
this pull request
Dec 5, 2021
This needs: dlang-community/dsymbol#175 to be merged Then DCD will need to pick up a version of dsymbol with that PR merged Once this is merged, we'll need to merge dlang-community#660
WebFreak001
pushed a commit
to RUSShyTwo/DCD
that referenced
this pull request
Oct 13, 2022
This needs: dlang-community/dsymbol#175 to be merged Then DCD will need to pick up a version of dsymbol with that PR merged Once this is merged, we'll need to merge dlang-community#660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because in an upcoming PR i have moved
This: https://github.com/Pure-D/serve-d/blob/aeae249f9fdc6269c7f4963907eb5ed645d0691c/source/served/commands/complete.d#L969
Into:
DCD/src/dcd/server/autocomplete/util.d
Line 756 in 2bfd3d0
Since it'll set the callTip for struct/class, this logic must be updated to take that into account