Adding tests for ufcs fundamental types #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebFreak001
requested changes
Nov 9, 2022
There was a problem hiding this comment.
there is a problem with integer and float types here: If you have a smaller integer, like short or byte, it can get implicitly upcast into an int. So we should probably change the type matching algorithm to somehow catch these implicit casts. (e.g. a function dsymbol implicitly casts into other dsymbol)
I think for alias this'd structs we need to cover that as well.
| @@ -2,4 +2,4 @@ set -e | |||
| set -u | |||
|
|
|||
| ../../bin/dcd-client $1 -c100 -I"$PWD"/fooutils file.d > actual.txt | |||
| diff actual.txt expected.txt | |||
| diff actual.txt expected.txt | |||
There was a problem hiding this comment.
removed last empty line here
There was a problem hiding this comment.
I'm not sure what you mean, by this comment.
|
you are right, I haven't thought about that. |
|
Included implicit integer upcast to matching algorithm of UFCS. |
WebFreak001
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added more tests for UFCS and updated readme according to types