Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added paren completion for UFCS (calltip completion) #691

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Added paren completion for UFCS (calltip completion) #691

merged 2 commits into from
Dec 7, 2022

Conversation

vushu
Copy link
Contributor

@vushu vushu commented Oct 23, 2022

I have added paren completion for UFCS, Im not sure if I need to remove the first param for the calltip.

WebFreak001
WebFreak001 requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@WebFreak001 WebFreak001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good otherwise

src/dcd/server/autocomplete/ufcs.d Show resolved Hide resolved
@WebFreak001 WebFreak001 merged commit 4fd12cf into dlang-community:master Dec 7, 2022
@vushu vushu deleted the ufcs_calltip_support branch March 6, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebFreak001 WebFreak001 WebFreak001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vushu @WebFreak001