Properly implement pointer types & resolve pointers, arrays and AAs in output #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebFreak001
force-pushed
the
improve-type-names
branch
from
f15651b
to
8ed150f
Compare
|
@WebFreak001 I have included your change to ufcs in my current PR. |
vushu
reviewed
Mar 16, 2023
vushu
reviewed
Mar 16, 2023
vushu
reviewed
Mar 16, 2023
vushu
approved these changes
Mar 16, 2023
- special DCD pointer symbols are actually inserted now - they are implicitly dereferenced (max 1 deref) for member access - index accessing them yields proper types (one pointer removed) - they return standard type properties on pointer pointers
typeOf field is new tab-delimited field in dcd-client output, so you no longer need to manually guess types / parse code. Calltips still yield the actual written type, but in case of "auto", the typeOf column may contain more useful info.
WebFreak001
force-pushed
the
improve-type-names
branch
from
c8d0a66
to
5e47f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes PR fix #715
@ryuukk this supersedes that PR you made that extended the type details to
foo -> Tsyntax. I decided to only have the resolved type here, there is a fallback to use the function name on unknown types though. We could probably expose this information elsewhere though and show it somehow in serve-d.@vushu there is a single UFCS line fix in here, which you probably want to include in your PR as well
If any of you could also review, that would be nice.