Adding ufcs to match with type of pointer #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah sorry that probably happened with my recent pointer DSymbol changes, although I would have expected things to be more exact now and actually match pointers better. Does this mean it also doesn't work with AAs, Arrays and function pointers? (since they all share this same DSymbol layout) |
|
UFCS completion for AAs, Arrays and function pointer isn't yet supported, so that needs to get implemented at some point. If you mean for standard completion then I don't know. |
|
why don't we also add support for arrays here? (since they are the exact same layout as pointers) AAs and function pointers we can move to another time, since they are still missing internal things to properly distinguish. |
|
@WebFreak001 I have included array matching as suggested. |
WebFreak001
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that UFCS completion didn't work correctly with pointer type, this PR should resolve it.