-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure UFCS correctness #733
Merged
WebFreak001
merged 3 commits into
dlang-community:master
from
WebFreak001:ensure-ufcs-correctness
May 17, 2023
Merged
Ensure UFCS correctness #733
WebFreak001
merged 3 commits into
dlang-community:master
from
WebFreak001:ensure-ufcs-correctness
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebFreak001
force-pushed
the
ensure-ufcs-correctness
branch
from
March 22, 2023 02:18
1c248d2
to
4d5e269
Compare
DCD BUILD FAILED Build statistics: statistics (-before, +after)
client size=1055832 bin/dcd-client
-server size=3018864 bin/dcd-server
-rough build time=92s
+server size=3031344 bin/dcd-server
+rough build time=89s
-DCD run_tests.sh
-DCD run_tests.sh
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.85
+DCD run_tests.sh Maximum resident set size (kbytes): 42472
+short requests: (227x)
+ min request time = 0.015ms
+ 10th percentile = 0.119ms
+ median time = 0.496ms
+ 90th percentile = 0.863ms
+ max request time = 1.778ms
+long requests over 10ms: (51x)
+ min request time = 17.275ms
+ 10th percentile = 19.482ms
+ median time = 21.818ms
+ 90th percentile = 26.957ms
+ max request time = 31.725ms
top 5 GC sources in server: Full build output
|
This was referenced Mar 22, 2023
WebFreak001
force-pushed
the
ensure-ufcs-correctness
branch
2 times, most recently
from
May 16, 2023 20:53
1955e66
to
f2521e3
Compare
WebFreak001
force-pushed
the
ensure-ufcs-correctness
branch
from
May 17, 2023 14:02
f2521e3
to
13e9e80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still needs fixes in UFCS code before merging
depends on #732
finds a bunch of incorrect suggestions from DCD. The extra suggestions aren't that bad right now, the missing suggestions are a bit worse.
This completely ignores template things though, we probably want to implement IFTI matching in a separate module / subpackage / library.