Bundle libcurl with the snap package #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DUB uses `std.net.curl` to download package data, which in turn relies on being able to dynamically load libcurl at runtime via `dlopen`. If libcurl is not available in the snap, but only on the host system, then DUB may not be able to locate it: this happens e.g. on Ubuntu 18.04 and quite possibly on other distros too. This patch adds a separate `curl` part that includes `libcurl3-gnutls` via `stage-packages`. This is simpler than adding it to the `dub` part as the `dump` plugin will not automatically stage packages specified in this way. Besides the libraries themselves, we need to add extra `LD_LIBRARY_PATH` settings to the app environment to enable dub to find them. The `license.txt` file has been updated to note the inclusion of these libraries and point the reader to copyright and licensing information. Adapted from an earlier PR by @philburr: dlang-snaps#13
|
Updated with a tweak to diff --git a/snap/license.txt b/snap/license.txt
index 626cd26..c0782b7 100644
--- a/snap/license.txt
+++ b/snap/license.txt
@@ -5,6 +5,10 @@ DUB is released under the MIT License. It statically links in druntime
and phobos (the D standard library), which are both released under the
Boost Software License (Version 1.0).
+This package also bundles `libcurl3-gnutls` and its dependencies. Copyright
+and licensing information for these libraries can be found in the `copyright`
+files in the `usr/share/doc/*` directories inside the package.
+
Full license texts
================== |
|
Confirmed that this works on 18.04 earlier today. I think we can take this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DUB uses
std.net.curlto download package data, which in turn relies on being able to dynamically load libcurl at runtime viadlopen. If libcurl is not available in the snap, but only on the host system, then DUB may not be able to locate it: this happens e.g. on Ubuntu 18.04 and quite possibly on other distros too.This patch adds a separate
curlpart that includeslibcurl3-gnutlsviastage-packages. This is simpler than adding it to thedubpart as thedumpplugin will not automatically stage packages specified in this way.Besides the libraries themselves, we need to add extra
LD_LIBRARY_PATHsettings to the app environment to enable dub to find them.Adapted from an earlier PR by @philburr: #13