Skip to content

Commit

Permalink
Merge pull request #180 from dlang-bots/dlangbot-improve-msg
Browse files Browse the repository at this point in the history
Improve the DLang-Bot message -> convert it into a simple checklist
  • Loading branch information
wilzbach committed Feb 11, 2018
2 parents e7c6f05 + 9a4d4dd commit 976dd89
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions source/dlangbot/github.d
Expand Up @@ -51,19 +51,20 @@ string formatComment(in ref PullRequest pr, in IssueRef[] refs, in Issue[] descs
else
{
app.formattedWrite(
`Thanks for your pull request, @%s! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
"Thanks for your pull request and interest in making D better, @%s! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:
Some tips to help speed things up:
- [ ] My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with [CodeCov's browser extension](https://github.com/codecov/browser-extension)
- [ ] My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- [ ] My PR follows the [DStyle](https://dlang.org/dstyle.html)
- [ ] I have provided a detailed rationale explaining my changes
- [ ] New or modified functions have Ddoc comments (with `Params:` and `Returns:`)
- smaller, focused PRs are easier to review than big ones
Please see [CONTRIBUTING.md](https://github.com/%s/blob/master/CONTRIBUTING.md) for more information.
- try not to mix up refactoring or style changes with bug fixes or feature enhancements
---
- provide helpful commit messages explaining the rationale behind each change
Bear in mind that large or tricky changes may require multiple rounds of review and revision.
Please see [CONTRIBUTING.md](https://github.com/%s/blob/master/CONTRIBUTING.md) for more information.`,
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.",
pr.user.login, pr.repoSlug);
}

Expand Down

0 comments on commit 976dd89

Please sign in to comment.