Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post a comment when auto-merge is toggled on #32

Closed
wilzbach opened this issue Dec 23, 2016 · 8 comments
Closed

Post a comment when auto-merge is toggled on #32

wilzbach opened this issue Dec 23, 2016 · 8 comments

Comments

@wilzbach
Copy link
Member

I prefer the auto-merge system actually posting the message that auto merge has been toggled on, because that goes to my inbox.

reported by @schveiguy

@schveiguy
Copy link
Member

Also should post when it's toggled off as well, for completeness!

@MartinNowak
Copy link
Member

Please not more comments, github already shows label added and label removed info, without sending lots of mails.

@schveiguy
Copy link
Member

Except I don't get notifications for the labels. All I will see is "dlang bot merged". Can we get a comment from the bot when merging on whose behalf? The merge commit doesn't get sent out in email either

@MartinNowak
Copy link
Member

You do get GH notifications for merges (and those can be mailed), should be enough.

@schveiguy
Copy link
Member

FYI: dlang/druntime#1743 (comment)

@MartinNowak
Copy link
Member

I'm not using mail in my GH workflow, so I might miss the point, but I'm very opposed to add even more noise.

@schveiguy
Copy link
Member

I'm not sure it's relevant to me anymore. I have learned to ignore the commit messages I see in my email, and look directly at the github discussion, and look for the labels before doing any reviews.

@CyberShadow
Copy link
Member

Usually auto-merge is enabled along with approving the PR, and approving does generate an email today, so hopefully that should be sufficient.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants