Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve issue linking info #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

John-Colvin
Copy link

@John-Colvin John-Colvin commented Dec 7, 2017

the regex seems a bit restrictive, it would have been good to know this info.

@wilzbach relating to our discussion here

@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @John-Colvin! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

@wilzbach
Copy link
Member

wilzbach commented Dec 7, 2017

Hmm quoting from the Bugzilla paragraph below:

Using this syntax is also very important because for the changelog generation, the git history will be used. Thus only if the Dlang-Bot has detected an issue and commented on your PR it can become part of the changelog.
In doubt, you can use e.g. Regex101 to validate your commit message.

Maybe simply linking or reordering the existing content?

@CyberShadow
Copy link
Member

What's the status of this considering that we now use our own Bugzilla integration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants