Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 18081 - dlangspec.pdf: don't escape dollars in code examples #1994

Merged
merged 1 commit into from Dec 15, 2017
Merged

Fix Issue 18081 - dlangspec.pdf: don't escape dollars in code examples #1994

merged 1 commit into from Dec 15, 2017

Conversation

wilzbach
Copy link
Member

Before:

image

After:

image

Before:

image

After:

image

See also: #1983

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Auto-close Bugzilla Description
✓ 18081 dlangspec.pdf: don't escape dollars in code examples

@wilzbach wilzbach mentioned this pull request Dec 15, 2017
Closed
@JinShil
Copy link
Contributor

JinShil commented Dec 15, 2017 •
edited

Is it just the font, or are those backticks actually single quotes? -- must be the font, the code looks right.

@dlang-bot dlang-bot merged commit 6f5d480 into dlang:master Dec 15, 2017
@wilzbach
Copy link
Member Author

Is it just the font, or are those backticks actually single quotes? -- must be the font, the code looks right.

Ah yes, we shouldn't execute the macro here nor use the $(DOLLAR).
-> #1996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinShil JinShil JinShil approved these changes

@andralex andralex Awaiting requested review from andralex andralex is a code owner

@WalterBright WalterBright Awaiting requested review from WalterBright WalterBright is a code owner

Assignees
No one assigned
Labels
auto-merge Enhancement
Projects
None yet
Milestone
No milestone
3 participants
@wilzbach @dlang-bot @JinShil