Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 18782 - Documentation error: ProtectionAttributes should say Visibility Attribute #2350

Merged
merged 2 commits into from Jun 18, 2018
Merged

fix issue 18782 - Documentation error: ProtectionAttributes should say Visibility Attribute #2350

merged 2 commits into from Jun 18, 2018

Conversation

aG0aep6G
Copy link
Contributor

Also removing an outdated sentence in the vicinity.

@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 20, 2018 •
edited

Thanks for your pull request and interest in making D better, @aG0aep6G! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 18782 minor Documentation error: ProtectionAttributes should say Visibility Attributes

@aG0aep6G
fix issue 18782 - Documentation error: ProtectionAttributes should sa…
7c32826 
…y Visibility Attribute

Also removing the outdated statement that visibility is not affected. Since
DIP22, `private`, `public`, etc. do affect visibility.
@aG0aep6G
Copy link
Contributor Author

Added a commit to fix similar wrong links in lex.html.

@aG0aep6G
Copy link
Contributor Author

Ping. This has been open for nearly two months without any reaction.

wilzbach
wilzbach approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the inactivity and thanks for the ping!

@wilzbach wilzbach merged commit 78a0986 into dlang:master Jun 18, 2018
@aG0aep6G aG0aep6G deleted the 18782 branch June 19, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilzbach wilzbach wilzbach approved these changes

@andralex andralex Awaiting requested review from andralex andralex is a code owner

@WalterBright WalterBright Awaiting requested review from WalterBright WalterBright is a code owner

Assignees
No one assigned
Labels
Bug Fix Enhancement
Projects
None yet
Milestone
No milestone
3 participants
@aG0aep6G @dlang-bot @wilzbach