Bump stable DUB/DMD #2432
Merged
Bump stable DUB/DMD #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
requested review from
andralex,
CyberShadow and
MartinNowak
as code owners
|
Shouldn't this target the stable branch, considering that's the branch that's failing? |
wilzbach
force-pushed
the
bump-stable-dmd
branch
from
b16b93e
to
85e96ac
Compare
|
Yes, sorry! Though it seems like |
|
Lol. So with the recent master to stable merge, the build issues of the stable branch seemed to have disappeared. So we probably don't need this anymore, but OTOH having a more recent dub binary doesn't never hurt either. |
PetarKirov
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this helps anything, but trying to dig to root of dlang/dmd#8519 (comment).