Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Return Scope Parameters section #2536

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

WalterBright
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

spec/function.dd Outdated
thorin(q); // ok
thorin(r); // ok

global(p); // error, gloin() escapes p
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gloin instead of global?

spec/function.dd Outdated
thorin(q); // ok
thorin(r); // ok

global(p); // error, gloin() escapes p
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gloin instead of global?

@thewilsonator
Copy link
Contributor

I'd rather the LotR references were dropped and just call then f,g and h.

@WalterBright
Copy link
Member Author

I got bored with the planets :-)

Anyhow, others have complained about the boringness of f(), func(), foo(), etc., and they do get tiresome.

@thewilsonator
Copy link
Contributor

https://github.com/Droogans/unmaintainable-code/blob/master/README.md#bedazzling-names

@wilzbach
Copy link
Member

@thewilsonator: this doesn't apply here as it's the documentation with no real code where fun names make the example more interesting.

@WalterBright
Copy link
Member Author

While the advice is good, the trouble is, those functions have no purpose and do nothing. But they are all from the same group, and are all in one group in one section. I find one letter function names a little off-putting.

Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea where the names come, but they sound fun.

@andralex andralex merged commit 28dff1b into dlang:master Jan 2, 2019
@WalterBright WalterBright deleted the return-scope branch January 3, 2019 00:33
@jacob-carlborg
Copy link
Contributor

No idea where the names come, but they sound fun.

They are names of the dwarfs in the The Hobbit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants