Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance deprecation of delete expressions, class allocators, class deallocators: Error #2631

Closed
wants to merge 1 commit into from
Closed

Conversation

JinShil
Copy link
Contributor

@JinShil JinShil commented Apr 21, 2019

Documentation update to accompany dlang/dmd#9666

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Contributor

@jacob-carlborg jacob-carlborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What’s the change, trailing whitespace?

@JinShil
Copy link
Contributor Author

JinShil commented Apr 21, 2019

What’s the change

If you look at https://dlang.org/deprecate.html you'll see the "Error" column is blank. After this is pulled, it will be populated with the DMD version number in which dlang/dmd#9666 appears. Right now I'm trying for 2.086, but I may have to update this PR to 2.087 if I can't get it done on time.

@JinShil JinShil changed the title Advance deprecation of delete expressions: Error Advance deprecation of delete expressions, class allocators, class deallocators: Error Apr 23, 2019
@JinShil JinShil closed this May 14, 2019
@JinShil JinShil deleted the dep_delete_error branch May 14, 2019 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants