Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 18960 - Function parameter requires name with default value #3135

Merged
merged 1 commit into from Dec 6, 2021

Conversation

sorin-gabriel
Copy link
Contributor

Closing the issue by adding clarifications in the spec. The behaviour mentioned in the issue actually seems reasonable (so it's not a bug), but the docs don't mention this anywhere.

@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 5, 2021

Thanks for your pull request and interest in making D better, @sorin-gabriel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@rikkimax
Copy link

rikkimax commented Dec 5, 2021

After reviewing my ticket, I cannot place what exactly I was referencing in the spec. I should have linked it.

Therefore I'm going to close it as invalid because I'm pretty sure I miss interpreted something related to function parameters.

However your example is good, just drop the reference to the ticket.

@RazvanN7 RazvanN7 merged commit 4a000dd into dlang:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants