Fix Issue 19869 - FunctionLiteral allows incorrect forms
#3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecifiedFunctionBody allows `do` and contracts. https://dlang.org/spec/function.html#SpecifiedFunctionBody
ntrel
requested review from
andralex,
WalterBright,
maxhaton and
mdparker
as code owners
|
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
ntrel
changed the title
FunctionLiteral allows incorrect formsFunctionLiteral allows incorrect forms
dkorpel
requested changes
Jul 25, 2022
| @@ -1854,7 +1854,7 @@ $(GNAME FunctionLiteral): | |||
| $(D function) $(D ref)$(OPT) $(GLINK2 type, Type)$(OPT) $(GLINK ParameterWithAttributes)$(OPT) $(GLINK FunctionLiteralBody2) | |||
| $(D delegate) $(D ref)$(OPT) $(GLINK2 type, Type)$(OPT) $(GLINK ParameterWithMemberAttributes)$(OPT) $(GLINK FunctionLiteralBody2) | |||
| $(D ref)$(OPT) $(GLINK ParameterWithMemberAttributes) $(GLINK FunctionLiteralBody2) | |||
| $(GLINK2 function, SpecifiedFunctionBody) | |||
| $(GLINK2 statement, BlockStatement) | |||
spec/expression.dd
Outdated
| @@ -1865,14 +1865,14 @@ $(GNAME ParameterWithMemberAttributes): | |||
|
|
|||
| $(GNAME FunctionLiteralBody2): | |||
| $(D =>) $(GLINK AssignExpression) | |||
| $(GLINK2 function, SpecifiedFunctionBody) | |||
| $(GLINK2 statement, BlockStatement) | |||
There was a problem hiding this comment.
But this one doesn't look right, this is allowed:
auto b = function int(int x) do {return true;};There was a problem hiding this comment.
Sorry, restored this line.
dkorpel
approved these changes
Jul 25, 2022
RazvanN7
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpecifiedFunctionBody allows
doand contracts.https://dlang.org/spec/function.html#SpecifiedFunctionBody