Fix Issue 22418 - Error in documentation on strings #3501
Conversation
andraam21
requested review from
andralex,
WalterBright,
maxhaton and
mdparker
as code owners
|
Thanks for your pull request and interest in making D better, @andraam21! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
error at immutable strings at str1
andraam21
changed the title
|
Please add a commit that contains "Fix Issue 22418" in the commit message so that dlang-bot auto-closes the issue when the PR is merged. |
There was a problem hiding this comment.
The PR does not fix the issue. The OP asks for a clarification on what happens here and in its current form the PR does not address that. To be accepted, this needs to:
- the comments must match the errors that the compiler outputs
- the difference between different combinations of immutable(char)[] or immutable(char[]) must be highlighted.
spec/arrays.dd
Outdated
| @@ -1008,10 +1008,11 @@ $(H3 $(LNAME2 strings, Strings)) | |||
| $(SPEC_RUNNABLE_EXAMPLE_FAIL | |||
| --------- | |||
| char[] str1 = "abc"; // error, "abc" is not mutable | |||
There was a problem hiding this comment.
The bug report asks for a redesign of this example because currently the errors do not match. For example, the line above yields:
cannot implicitly convert expression `"abc"` of type `string` to `char[]`
spec/arrays.dd
Outdated
| immutable(char)[] str3 = "abc"; // ok | ||
| immutable(char)[] str4 = str1; // error, str4 is not mutable | ||
| immutable(char)[] str5 = str1.idup; // ok, make immutable copy | ||
| immutable(char)[] str4 = str2; // error, str4 is not mutable |
There was a problem hiding this comment.
This is not the error that the compiler outputs.
Added the compiler errors and the difference between immutable(char)[] and immutable(char[])
andraam21
changed the title
spec/arrays.dd
Outdated
| int[4] a = 42; // set all elements of a to 42 | ||
|
|
||
| assert(a == [42, 42, 42, 42]); | ||
| --------- |
There was a problem hiding this comment.
This seems to be unrelated to this PR. Maybe you somehow screwed the rebase?
Updated the explanation
spec/arrays.dd
Outdated
| int[4] a = 42; // set all elements of a to 42 | ||
|
|
||
| assert(a == [42, 42, 42, 42]); | ||
| --------- |
There was a problem hiding this comment.
this should not be deleted.
spec/arrays.dd
Outdated
| --------- | ||
| ) | ||
| $(P | ||
| The type immutable(char)[] represents an array of immutable chars. However, the reference to the string is |
There was a problem hiding this comment.
please highlight the compiler keyword : immutable(char)[], immutable string etc.
Highlighted the words and added the missing part
white spaces fixed
No description provided.