add documentation for getModuleClasses #3524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
requested review from
andralex,
maxhaton and
mdparker
as code owners
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
adamdruppe
reviewed
Feb 10, 2023
| @@ -1330,6 +1330,31 @@ void main() | |||
| --- | |||
| ) | |||
|
|
|||
| $(H3 $(GNAME getModuleClasses)) | |||
|
|
|||
| $(P Optionally takes one argument which is a module name or a fully qualified import. | |||
There was a problem hiding this comment.
What happens if you do import a = std.stdio;? Is a considered fully qualified at that point?
What if you use it on an imported symbol instead of an imported module?
It also isn't really a module name per se, but rather a module symbol, since it isn't quoted.
adamdruppe
reviewed
Feb 10, 2023
|
|
||
| $(P Optionally takes one argument which is a module name or a fully qualified import. | ||
| If there is no argument, the current module is used. | ||
| It returns a tuple of strings representing the fully qualified names of classes defined in |
There was a problem hiding this comment.
What use case does this have?
|
Closing, as the addition was reverted (dlang/dmd#14892) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation: dlang/dmd#14699