Fix Issue 23946 - spec states "there can only be one destructor" #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structor" ...which can be confusing because of mixin templates
ntrel
requested review from
andralex,
WalterBright,
maxhaton and
mdparker
as code owners
|
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
dkorpel
reviewed
Jun 10, 2023
| $(P There can be only one destructor per class, the destructor | ||
| does not have any parameters, | ||
| $(P There can be only one destructor declared per class, although | ||
| other destructors $(DDSUBLINK spec/template-mixin, destructors, can be mixed in). |
There was a problem hiding this comment.
Is this intentional behavior?
There was a problem hiding this comment.
Yes, but it was never written. Destructors of member variables are all called alongside the declared one, and a mixin template is a special kind of member. It is basically an embedded struct with its names exposed to the top level scope.
dkorpel
approved these changes
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which can be confusing because of mixin templates