Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec/function] Fix Safe Interface definition #3789

Merged
merged 2 commits into from Mar 30, 2024
Merged

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Mar 23, 2024

  1. Mention safe context and globals for preconditions.
    Part of Bugzilla 24098 - Safe variable can be initialized from @system static constructor.

  2. @trusted functions can create unsafe values/aliasing so long as they are not accessible from @safe code. E.g. setting a @system field.

1. Mention context and globals for preconditions.
Part of Bugzilla 24098 - Safe variable can be initialized from `@system`
static constructor.

2. `@trusted` functions can create unsafe values/aliasing so long as they
are not accessible from `@safe` code.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24098 normal Safe variable can be initialized from `@system` static constructor.

@ntrel ntrel changed the title [spec] Fix Safe interface definition [spec/function] Fix Safe Interface definition Mar 23, 2024
@dkorpel dkorpel merged commit fe84774 into dlang:master Mar 30, 2024
2 checks passed
@ntrel ntrel deleted the safe-iface branch March 30, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants