Add the Z 'type' to the mangling ABI to denote internal symbols. #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion here: dlang/druntime#725 D already creates mangled names using the Z symbol for internal symbols, e.g. _D3foo3Bar6__vtblZ for the virtual table for class foo.Bar. The ABI makes no mention of these symbols. This pull request adds Z to the mangling ABI to make these official symbols. The linked pull request implements that demangling.
|
LGTM. |
MartinNowak
added a commit
that referenced
this pull request
Oct 11, 2014
Add the Z 'type' to the mangling ABI to denote internal symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion here: dlang/druntime#725
D already creates mangled names using the Z symbol for internal symbols, e.g.
_D3foo3Bar6__vtblZ for the virtual table for class foo.Bar. The ABI makes no
mention of these symbols. This pull request adds Z to the mangling ABI to make
these official symbols. The linked pull request implements that demangling.