Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove margin top from the home page heading #835

Merged
merged 2 commits into from Jan 24, 2015

Conversation

aG0aep6G
Copy link
Contributor

It slipped through CSS, because it's not an <h1>.

Before/after:
iconscreenshot1

It slipped through CSS, because it's not an <h1>.
@CyberShadow
Copy link
Member

What about the "Improve this page" buttons?

@aG0aep6G
Copy link
Contributor Author

Yeah, they're clashing with the slogan now, forcing it to break:

iconscreenshot1

It's the same as on every other page now. But the home page is exceptionally long, of course, so that it happens easier.

I don't think it's too problematic. The slogan is overly long anyway. It has to be expected that it's broken in smaller windows.

@CyberShadow
Copy link
Member

OK, then how about making the slogan only break if necessary, so it prefers a break after "The D programming language."?

diff --git a/index.dd b/index.dd
index fcb176d..42c51bd 100644
--- a/index.dd
+++ b/index.dd
@@ -2,8 +2,7 @@ Ddoc

 $(D_S D Programming Language,

-$(SECTION3 The D programming language. Modern
-convenience. Modeling power. Native efficiency.,
+$(SECTION3 The D programming language. $(SPAN style="display: inline-block", Modern convenience. Modeling power. Native efficiency.),

 Conference websites, videos and slides:
 $(UL

@aG0aep6G
Copy link
Contributor Author

Sure thing. Updated.

CyberShadow added a commit that referenced this pull request Jan 24, 2015
remove margin top from the home page heading
@CyberShadow CyberShadow merged commit 870183c into dlang:master Jan 24, 2015
@aG0aep6G aG0aep6G deleted the slogan-margin-top branch January 24, 2015 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants