Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Seperate core.sys.signal architecture support into separate files #1255

Closed
wants to merge 1 commit into from

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented May 5, 2015

This implements #744 but using a more complex module.

I'm still not convinced this is the right way to go about it...

@WalterBright feel free to review.

@ibuclaw ibuclaw changed the title Seperate architecture support into separate files Seperate core.sys.signal architecture support into separate files May 5, 2015
@MartinNowak
Copy link
Member

So is this really an improvement?
It's already a huge PITA to keep the different sections.d implementations aligned, and I ended up remerging the more complicated sections_elf_shared for FreeBSD and Linux.

@ibuclaw
Copy link
Member Author

ibuclaw commented May 17, 2015

So is this really an improvement?

I'm not sold on this method, but people also weren't sold on my proposal either. What I am certain about is that this is something that can't be continually ignored.

It's already a huge PITA to keep the different sections.d implementations aligned,

Would it be a bigger PITA if they were all bunched together in one file?

I envisioned that we'd hit some sort of brick wall on the burden of adding ports and general maintenance hell a couple of years back. Maybe it's not as serpentine as I made it out, but a couple of questions I'd pose are:

  • When porting to a new architecture, how easy was it to find and correct problems at runtime when crossing the D <-> C boundaries?

We are in a better position now than what we were two years back, but there are still places where relaxed version conditions may allow things to fall through.

  • Would the port to Android x86/ARM have been easier if platforms/targets were split up?

This is something I can leave you to ponder over.

@MartinNowak
Copy link
Member

Would it be a bigger PITA if they were all bunched together in one file?

It's ugly, but it doesn't hurt much, except for lexing/parsing overhead maybe, which hasn't been a huge problem so far.

We are in a better position now than what we were two years back, but there are still places where relaxed version conditions may allow things to fall through.

This is something that can be fixed without changing the file layout.

Would the port to Android x86/ARM have been easier if platforms/targets were split up?

Apart from a few unterminated version conditions, I'd say no.

@RazvanN7
Copy link
Contributor

@ibuclaw what's the status of this?

@Geod24
Copy link
Member

Geod24 commented Jul 9, 2022

Druntime have been merged into DMD. Please re-submit your PR to dlang/dmd repository.

@Geod24 Geod24 closed this Jul 9, 2022
@ibuclaw ibuclaw deleted the reboot744 branch July 10, 2022 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs Rebase needs a `git rebase` performed Needs Work stalled
Projects
None yet
5 participants