This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Issue 8973 - core.cpuid.coresPerCPU returning incorrect value. #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while (apicsize) { maxCores<<=1; --apicsize; } | ||
| //http://support.amd.com/TechDocs/25481.pdf pg.36 | ||
| maxCores = 1; | ||
| if (hyperThreadingBit) { |
There was a problem hiding this comment.
This is reffered to a legacy method. Any reasons the so-called extended method cannot be used?
There was a problem hiding this comment.
Using NC is the listed way to do it under the extended method. I believe the 'legacy' is referring to the deprecated LogicalProcessorCount, not NC.
There was a problem hiding this comment.
Yes, you are right. All bits were confusingly list in legacy method section, still the only legacy fields are LogicalCpuCount and CmpLegacy
|
Auto-merge toggled on |
DmitryOlshansky
added a commit
that referenced
this pull request
Aug 23, 2015
Issue 8973 - core.cpuid.coresPerCPU returning incorrect value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxCores for AMD is currently calculated using the theoretical maximum number of cores, not the actual enabled maximum number of cores.
This causes all bulldozer CPUs(and possibly others) to report the wrong value.
http://support.amd.com/TechDocs/25481.pdf
issue