Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Move deprecations along in core.time. #1369

Merged
merged 1 commit into from Aug 30, 2015

Conversation

jmdavis
Copy link
Member

@jmdavis jmdavis commented Aug 29, 2015

No description provided.


$(D d.get!"minutes"()) is equivalent to $(D d.split().minutes).
+/
// Explicitly undocumented. It will be removed in August 2016. @@@DEPRECATED_2016-08@@@
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never understood the purpose of not documenting stuff. How would somebody get rid of a deprecated thingie if there is no docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation message tells folks what to change their code to use. The documentation is unnecessary for that.

It's undocumented so that no one will see it in the documentation and choose to use it and so that it won't clutter the documentation. In theory, anyone who's actually maintaining their code will have already updated their code to not use this function, but by leaving it around as undocumented at least for now, we give folks more time to fix their code if they haven't yet while still having made it far less likely for new code to mistakenly use it.

In either case, the deprecation message tells folks what to use instead, and they can look at the documentation for that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but by leaving it around as undocumented at least for now, we give folks more time to fix their code if they haven't yet while still having made

And doing so without documentation on what it does in the first place makes porting old stuff that muh harder. Anyway I'm just wasting time on this as our discussion certianly won't change the way things are carried out.

@DmitryOlshansky
Copy link
Member

Auto-merge toggled on

DmitryOlshansky added a commit that referenced this pull request Aug 30, 2015
Move deprecations along in core.time.
@DmitryOlshansky DmitryOlshansky merged commit 44e41db into dlang:master Aug 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants