Add new options for Linux's fallocate(2)

[Burgos]

Linux's fallocate in the kernels newer than 3.15
brings three new options:

FALLOC_FL_COLLAPSE_RANGE
FALLOC_FL_ZERO_RANGE
FALLOC_FL_INSERT_RANGE

which are now defined in fcntl.d

[PetarKirov]

For reference:
http://man7.org/linux/man-pages/man2/fallocate.2.html
http://lxr.free-electrons.com/source/include/uapi/linux/falloc.h

[nemanja-boric-sociomantic]

Any way to trigger the testers without ammending and pushing?

[wilzbach]

Any way to trigger the testers without ammending and pushing?

Auto-tester automatically rebuilds the PRs from time to time, but unfortunately CircleCi doesn't.
The easiest is closing and reopening the issue (and of course contributors can go to CircleCi and click for a rebuild). We are working actively to improve the CI situation, so hopefully less annoyance in the future ;-)

[Burgos]

The easiest is closing and reopening the issue (and of course contributors can go to CircleCi and click for a rebuild)

Thanks, I just gave it a go!

[wilzbach]

Thanks, I just gave it a go!

It seems this didn't work either :S
Maybe you could try it again?

[Burgos]

Rebased on master and now all tests (except autotester which is running) are passing.

[PetarKirov]

Ping @jmdavis @schveiguy this looks good to go.

[wilzbach]

I guess we should add FALLOC_FL_UNSHARE_RANGE as well?

[wilzbach]

Looking at https://github.com/torvalds/linux/blob/v4.11/include/uapi/linux/falloc.h, it seems that

FALLOC_FL_UNSHARE_RANGE		0x40

has been added in the meantime.
It was added in October 2016: torvalds/linux@71be6b4

[Burgos]

Yup, good point, will add during the day.

…

On 11 May 2017 10:42 am, "Sebastian Wilzbach" ***@***.***> wrote: ***@***.**** requested changes on this pull request. I guess we should add FALLOC_FL_UNSHARE_RANGE as well? ------------------------------ In src/core/sys/linux/fcntl.d <#1681 (comment)>: > @@ -10,7 +10,10 @@ nothrow: enum { FALLOC_FL_KEEP_SIZE = 0x01, FALLOC_FL_PUNCH_HOLE = 0x02, - FALLOC_FL_NO_HIDE_STALE = 0x04 + FALLOC_FL_NO_HIDE_STALE = 0x04, + FALLOC_FL_COLLAPSE_RANGE = 0x08, + FALLOC_FL_ZERO_RANGE = 0x10, + FALLOC_FL_INSERT_RANGE = 0x20 Looking at https://github.com/torvalds/linux/blob/v4.11/include/uapi/ linux/falloc.h, it seems that FALLOC_FL_UNSHARE_RANGE 0x40 has been added in the meantime. It was added in October 2016: ***@***.*** <torvalds/linux@71be6b4> — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1681 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA9wef2wILWECXZyPX0x587bQF_HdLvWks5r4snvgaJpZM4KeFl_> .

[Burgos]

Updated!

[wilzbach]

LGTM, thanks!

[wilzbach]

@ other reviewers, for convenience the falloc header file can be e.g. found here https://github.com/torvalds/linux/blob/v4.11/include/uapi/linux/falloc.h

[nemanja-boric-sociomantic]

Ha, thanks! I forgot about this one :-

[wilzbach]

Ha, thanks! I forgot about this one :-

Same here. Let's get this in then!