Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

fix issue 15482 - new uuid.d forbids to link statically with other libs #2063

Merged
merged 2 commits into from
Jan 28, 2018
Merged

fix issue 15482 - new uuid.d forbids to link statically with other libs #2063

merged 2 commits into from
Jan 28, 2018

Conversation

rainers
Copy link
Member

@rainers rainers commented Jan 27, 2018

remove "export extern (C)" from IIDs to not conflict with uuid.lib from the platform SDK

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close Bugzilla Description
✓ 15482 new uuid.d forbids to link statically with other libraries

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Jan 27, 2018
@rainers rainers mentioned this pull request Jan 27, 2018
Closed
CyberShadow
CyberShadow approved these changes Jan 27, 2018
View reviewed changes
Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

test/uuid/test.d

void main()
{
assert(IID_IDirect3DNullDevice != IID_IDelayedPropertyStoreFactory);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rainers
fix issue 15482 - new uuid.d forbids to link statically with other li…
f9e92a0 
…braries

remove "export extern (C)" from IIDs to not conflict with uuid.lib from the platform SDK
@wilzbach
Copy link
Member

Permanently failing on win32_64:

cd test\uuid
make -f win64.mak "DMD=../dmd/generated/windows/release/32/dmd.exe" MODEL=64 "VCDIR=" DRUNTIMELIB=lib\druntime64.lib test
../dmd/generated/windows/release/32/dmd.exe -m64 -conf= -I..\..\src -defaultlib=lib\druntime64.lib test.d uuid.lib
Error: '../dmd/generated/windows/release/32/dmd.exe' not found

--- errorlevel 1

@andralex andralex merged commit f2f3f24 into dlang:master Jan 28, 2018
@rainers rainers mentioned this pull request Jan 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CyberShadow CyberShadow CyberShadow approved these changes

@andralex andralex andralex approved these changes

@wilzbach wilzbach Awaiting requested review from wilzbach

Assignees
No one assigned
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
Milestone
No milestone
5 participants
@rainers @dlang-bot @wilzbach @CyberShadow @andralex