Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Issue 18332 - rt.util.random.Rand48 remove unnecessary assert #2069

Merged
merged 1 commit into from Mar 12, 2018

Conversation

n8sh
Copy link
Member

@n8sh n8sh commented Jan 30, 2018

There is no need for seedval to be non-zero. The assertion should be removed.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @n8sh! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close Bugzilla Description
18332 rt.util.random.Rand48 remove unnecessary assert

@wilzbach
Copy link
Member

Thanks. Sorry that this PR got lost. Druntime seems to be low-traffic at the moment.

@wilzbach wilzbach merged commit 01643aa into dlang:master Mar 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants